[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-bugs
Subject:    [Wireshark-bugs] [Bug 11743] Add FTDI USB dissector
From:       bugzilla-daemon () wireshark ! org
Date:       2020-01-29 15:36:35
Message-ID: bug-11743-15-lRX9U3BNmX () https ! bugs ! wireshark ! org/bugzilla/
[Download RAW message or body]

--15803121954.48872E5f1.11404
Date: Wed, 29 Jan 2020 15:36:35 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.wireshark.org/bugzilla/
Auto-Submitted: auto-generated

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11743

--- Comment #19 from Joel Holdsworth <joel@airwebreathe.org.uk> ---
I just tested your new patches. It's now beginning to decode the TX packets
quite nicely.

As I'm sure you're aware, you still don't have disection of the "Set Data bits
LowByte" and "HighByte" fields (these labels are a bit ugly), but this should
be very simple to implement.

One minor issue: I had to mark the "tree" parameter of
"estimated_command_parameters_length" as unused to prevent a compiler error.

Anyway... the code is still quite simple, and yet it's good enough for me to
reverse engineer the functionality of the software I'm trying to replicate.

Nice work.

-- 
You are receiving this mail because:
You are watching all bug changes.
--15803121954.48872E5f1.11404
Date: Wed, 29 Jan 2020 15:36:35 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.wireshark.org/bugzilla/
Auto-Submitted: auto-generated

<html>
    <head>
      <base href="https://bugs.wireshark.org/bugzilla/" />
      <style>
        body, th, td {
            font-size: 12px;
            font-family: Arial, Helvetica, sans-serif; }
        p, pre { margin-top: 1em; }
        pre {
            font-family: Bitstream Vera Sans Mono, Consolas, Lucida Console, \
monospace;  white-space: pre-wrap;
	}
        table { border: 0; border-spacing: 0; border-collapse: collapse; }
        th, td {
            padding: 0.25em;
            padding-left: 0.5em;
            padding-right: 0.5em;
        }
        th { background: rgb(240, 240, 240); }
        th.th_top { border-bottom: 1px solid rgb(116, 126, 147); }
        th.th_left { border-right: 1px solid rgb(116, 126, 147); }
        td.removed { background-color: #ffcccc; }
        td.added { background-color: #e4ffc7; }
      </style>
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_CONFIRMED "
   title="CONFIRMED - Add FTDI USB dissector"
   href="https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11743#c19">Comment # \
19</a>  on <a class="bz_bug_link 
          bz_status_CONFIRMED "
   title="CONFIRMED - Add FTDI USB dissector"
   href="https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11743">bug 11743</a>
              from <span class="vcard"><a class="email" \
href="mailto:joel&#64;airwebreathe.org.uk" title="Joel Holdsworth \
&lt;joel&#64;airwebreathe.org.uk&gt;"> <span class="fn">Joel Holdsworth</span></a> \
                </span></b>
        <pre>I just tested your new patches. It's now beginning to decode the TX \
packets quite nicely.

As I'm sure you're aware, you still don't have disection of the &quot;Set Data bits
LowByte&quot; and &quot;HighByte&quot; fields (these labels are a bit ugly), but this \
should be very simple to implement.

One minor issue: I had to mark the &quot;tree&quot; parameter of
&quot;estimated_command_parameters_length&quot; as unused to prevent a compiler \
error.

Anyway... the code is still quite simple, and yet it's good enough for me to
reverse engineer the functionality of the software I'm trying to replicate.

Nice work.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are watching all bug changes.</li>
      </ul>
    </body>
</html>
--15803121954.48872E5f1.11404--


[Attachment #3 (text/plain)]

___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
             mailto:wireshark-bugs-request@wireshark.org?subject=unsubscribe

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic