[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-bugs
Subject:    [Wireshark-bugs] [Bug 15454] Dissection of CAN packets based on a DBC specification
From:       bugzilla-daemon () wireshark ! org
Date:       2019-03-30 11:22:31
Message-ID: bug-15454-15-OnZZeiE1uU () https ! bugs ! wireshark ! org/bugzilla/
[Download RAW message or body]

--15539449522.e5Eb.7198
Date: Sat, 30 Mar 2019 11:22:32 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.wireshark.org/bugzilla/
Auto-Submitted: auto-generated

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15454

--- Comment #9 from Maksim Salau <maksim.salau@gmail.com> ---
Hi Guy

(In reply to Guy Harris from comment #8)
> Either Flex & Bison/BYACC (if there's any .y file in the Wireshark source
> that works only with Bison, not Berkeley YACC, that's a bug), or Flex &
> Lemon (most of the generated parsers in Wireshark are Lemon, not
> Bison/BYACC).

Please elaborate on byacc compatibility.

I've implemented the parser with flex & bison. Just a parser, no integration
into wireshark dissector yet. I've chosen bison, since I'm new to describing
parser syntax and help with bison is easier available to me :)

I tried byacc and it works fine with valid input. But if I induce errors I get
memory leaks, since byacc shipped with Fedora doesn't have support for btyacc
extensions and thus I'm not allowed to use %destructor directive to get rid of
memory allocated data.

So here is the question: does Wireshark require btyacc extensions to be
enabled?

Here is what I get:
  $ byacc -L
  byacc: w - -L flag unsupported, reconfigure with --enable-btyacc

Since lemon parser generator looks more predictable across platforms for
obvious reasons, I consider rewriting parser using lemon, if there will be no
way ensure btyacc extensions presence.

Regards,
Maksim

-- 
You are receiving this mail because:
You are watching all bug changes.
--15539449522.e5Eb.7198
Date: Sat, 30 Mar 2019 11:22:32 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.wireshark.org/bugzilla/
Auto-Submitted: auto-generated

<html>
    <head>
      <base href="https://bugs.wireshark.org/bugzilla/" />
      <style>
        body, th, td {
            font-size: 12px;
            font-family: Arial, Helvetica, sans-serif; }
        p, pre { margin-top: 1em; }
        pre {
            font-family: Bitstream Vera Sans Mono, Consolas, Lucida Console, \
monospace;  white-space: pre-wrap;
	}
        table { border: 0; border-spacing: 0; border-collapse: collapse; }
        th, td {
            padding: 0.25em;
            padding-left: 0.5em;
            padding-right: 0.5em;
        }
        th { background: rgb(240, 240, 240); }
        th.th_top { border-bottom: 1px solid rgb(116, 126, 147); }
        th.th_left { border-right: 1px solid rgb(116, 126, 147); }
        td.removed { background-color: #ffcccc; }
        td.added { background-color: #e4ffc7; }
      </style>
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_CONFIRMED "
   title="CONFIRMED - Dissection of CAN packets based on a DBC specification"
   href="https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15454#c9">Comment # \
9</a>  on <a class="bz_bug_link 
          bz_status_CONFIRMED "
   title="CONFIRMED - Dissection of CAN packets based on a DBC specification"
   href="https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15454">bug 15454</a>
              from <span class="vcard"><a class="email" \
href="mailto:maksim.salau&#64;gmail.com" title="Maksim Salau \
&lt;maksim.salau&#64;gmail.com&gt;"> <span class="fn">Maksim Salau</span></a> \
</span></b>  <pre>Hi Guy

(In reply to Guy Harris from <a href="show_bug.cgi?id=15454#c8">comment #8</a>)
<span class="quote">&gt; Either Flex &amp; Bison/BYACC (if there's any .y file in the \
Wireshark source &gt; that works only with Bison, not Berkeley YACC, that's a bug), \
or Flex &amp; &gt; Lemon (most of the generated parsers in Wireshark are Lemon, not
&gt; Bison/BYACC).</span >

Please elaborate on byacc compatibility.

I've implemented the parser with flex &amp; bison. Just a parser, no integration
into wireshark dissector yet. I've chosen bison, since I'm new to describing
parser syntax and help with bison is easier available to me :)

I tried byacc and it works fine with valid input. But if I induce errors I get
memory leaks, since byacc shipped with Fedora doesn't have support for btyacc
extensions and thus I'm not allowed to use %destructor directive to get rid of
memory allocated data.

So here is the question: does Wireshark require btyacc extensions to be
enabled?

Here is what I get:
  $ byacc -L
  byacc: w - -L flag unsupported, reconfigure with --enable-btyacc

Since lemon parser generator looks more predictable across platforms for
obvious reasons, I consider rewriting parser using lemon, if there will be no
way ensure btyacc extensions presence.

Regards,
Maksim</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are watching all bug changes.</li>
      </ul>
    </body>
</html>
--15539449522.e5Eb.7198--


[Attachment #3 (text/plain)]

___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
             mailto:wireshark-bugs-request@wireshark.org?subject=unsubscribe

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic