[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-bugs
Subject:    [Wireshark-bugs] [Bug 1667] New: Missing check in mpeg-2 ts parser
From:       bugzilla-daemon () wireshark ! org
Date:       2007-06-26 1:52:27
Message-ID: bug-1667-15 () http ! bugs ! wireshark ! org/bugzilla/
[Download RAW message or body]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1667

           Summary: Missing check in mpeg-2 ts parser
           Product: Wireshark
           Version: 0.99.5
          Platform: PC
        OS/Version: FreeBSD
            Status: NEW
          Severity: Normal
          Priority: Medium
         Component: Wireshark
        AssignedTo: wireshark-bugs@wireshark.org
        ReportedBy: pete@altadena.net


Build Information:
wireshark 0.99.5

Copyright 1998-2007 Gerald Combs <gerald@wireshark.org> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.10.13, with GLib 2.12.12, with libpcap 0.9.5, with libz
1.2.3, with libpcre 7.1, with Net-SNMP 5.3.1, with ADNS, without Lua, with
GnuTLS 1.6.2, with Gcrypt 1.2.4, with Heimdal Kerberos, with PortAudio <= V18,
without AirPcap.

Running on FreeBSD 6.2-STABLE, with libpcap version 0.9.5.

Built using gcc 3.4.6 [FreeBSD] 20060305.

--
The case of adaption + payload is missing.

diff follows:
--- packet-mp2t.c       Thu Feb  1 18:00:34 2007
+++ packet-mp2t.c.new   Mon Jun 25 21:25:29 2007
@@ -390,7 +390,7 @@
                }
        }

-       if (afc == 0 || afc == 1) {
+       if (afc == 0 || afc == 1 || afc == 3) {
                gint payload_len;

                payload_len = MP2T_PACKET_SIZE - (offset - start_offset);
************
Also, really, afc==0 is illegal; however one should display the whole packet as
payload so
the next packet will be found correctly, which is what this does as is.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
Wireshark-bugs mailing list
Wireshark-bugs@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-bugs

[prev in list] [next in list] [prev in thread] [next in thread]