[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wink-dev
Subject:    Re: [jira] [Updated] (WINK-364) ApacheHttpClientConnectionHandler: openConnection should be synchron
From:       Raymond Feng <enjoyjava () gmail ! com>
Date:       2012-03-30 1:17:54
Message-ID: 58985F21-5218-4FF1-ADC6-AE38E45B5AB1 () gmail ! com
[Download RAW message or body]

I'll take a look. Thanks for the patch.

Raymond Feng
Sent from my iPhone

On Mar 29, 2012, at 6:13 PM, "Seshu Pasam (Updated) (JIRA)" <jira@apache.org> wrote:

> 
> [ https://issues.apache.org/jira/browse/WINK-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
> ] 
> Seshu Pasam updated WINK-364:
> -----------------------------
> 
> Summary: ApacheHttpClientConnectionHandler: openConnection should be synchronized, \
> should be thread safe and support connection pooling  (was: \
> ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be \
> thread pool and support connection pooling) 
> Can someone review and apply the patch please?
> 
> Who should I contact to get commit privileges? Thanks
> 
> > ApacheHttpClientConnectionHandler: openConnection should be synchronized, should \
> >                 be thread safe and support connection pooling
> > ------------------------------------------------------------------------------------------------------------------------------
> >  
> > Key: WINK-364
> > URL: https://issues.apache.org/jira/browse/WINK-364
> > Project: Wink
> > Issue Type: Bug
> > Components: Client
> > Affects Versions: 1.1.4
> > Reporter: Seshu Pasam
> > Labels: patch
> > Attachments: wink-client-apache-httpclient.diff
> > 
> > 
> > I found the following issues when using ApacheHttpClientConnectionHandler:
> > a.) openConnection() should be synchronized. It need not be synchronized if the \
> > httpClient was passed in, but that is typically not the case b.) \
> > ApacheHttpClientConnectionHandler should be thread safe and support connection \
> > pooling c.) Deprecated method usage
> > d.) Request not properly aborted when exceptions are thrown by \
> > httpClient#execute() I will attach a patch. Please review and apply the patch. \
> > Thanks
> 
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: \
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more \
> information on JIRA, see: http://www.atlassian.com/software/jira 
> 


[prev in list] [next in list] [prev in thread] [next in thread]