[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-patches
Subject:    ole32: Do not open registry keys with no access rights.
From:       Thomas Faber <thomas.faber () reactos ! org>
Date:       2016-02-29 15:49:28
Message-ID: 56D46888.1080401 () reactos ! org
[Download RAW message or body]

While simply opening a subkey (as done here) does not require any
access rights in particular, NtOpenKey with 0 desired access always
fails with STATUS_ACCESS_DENIED on Windows.
Consequently specifying a nonzero access is a prerequisite for some day
fixing Wine's NtOpenKey behavior in this regard.

["0002-ole32-Do-not-open-registry-keys-with-no-access-right.patch" (text/x-diff)]

From 1cccee5d8f531de0ff7b1adeae579035b0e04944 Mon Sep 17 00:00:00 2001
From: Thomas Faber <thomas.faber@reactos.org>
Date: Fri, 27 Nov 2015 12:26:16 +0100
Subject: ole32: Do not open registry keys with no access rights.

Signed-off-by: Thomas Faber <thomas.faber@reactos.org>
---
 dlls/ole32/comcat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ole32/comcat.c b/dlls/ole32/comcat.c
index 46a722e..eb5a927 100644
--- a/dlls/ole32/comcat.c
+++ b/dlls/ole32/comcat.c
@@ -245,7 +245,7 @@ static HRESULT COMCAT_IsClassOfCategories(
 	if (res != ERROR_SUCCESS) return S_FALSE;
 	for (string = impl_strings; *string; string += CHARS_IN_GUID) {
 	    HKEY catkey;
-	    res = open_classes_key(subkey, string, 0, &catkey);
+	    res = open_classes_key(subkey, string, READ_CONTROL, &catkey);
 	    if (res != ERROR_SUCCESS) {
 		RegCloseKey(subkey);
 		return S_FALSE;
-- 
2.7.0.windows.1





[prev in list] [next in list] [prev in thread] [next in thread]