[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-patches
Subject:    [AppDB] improve button names and fix form data
From:       Alexander Nicolaysen =?iso-8859-1?q?S=F8rnes?= <alex () thehandofagony ! com>
Date:       2006-11-30 17:31:48
Message-ID: 200611301831.48414.alex () thehandofagony ! com
[Download RAW message or body]

Make the meaning of the buttons more clear to the user by changing 'be a 
maintainer for this app' to 'be a maintainer for this version', and 
change 'monitor version' to 'monitor changes'.

Also fix cases where the input tags did not have quotes around the version 
property.


Regards,

Alexander N. Sørnes

["version.php.diff" (text/x-diff)]

Index: include/version.php
===================================================================
RCS file: /home/wine/appdb/include/version.php,v
retrieving revision 1.84
diff -u -p -r1.84 version.php
--- include/version.php	25 Nov 2006 17:24:45 -0000	1.84
+++ include/version.php	30 Nov 2006 17:24:43 -0000
@@ -540,7 +540,7 @@ class Version {
         echo html_frame_start("Version Form", "90%", "", 0);
         echo "<table width='100%' border=0 cellpadding=2 cellspacing=0>\n";
 
-        echo '<input type="hidden" name="iVersionId" value='.$this->iVersionId.' \
/>'; +        echo '<input type="hidden" name="iVersionId" \
value="'.$this->iVersionId.'" />';  
         if($editParentApplication)
         {
@@ -552,7 +552,7 @@ class Version {
             echo '</td></tr>',"\n";
         } else
         {
-            echo '<input type="hidden" name="iAppId" value='.$this->iAppId.' />';
+            echo '<input type="hidden" name="iAppId" value="'.$this->iAppId.'" />';
         }
 
         // version name
@@ -583,8 +583,8 @@ class Version {
             echo html_frame_end();
         } else
         {
-            echo '<input type="hidden" name="sMaintainerRating" \
                value='.$this->sTestedRating.' />';
-            echo '<input type="hidden" name="sMaintainerRelease" \
value='.$this->sTestedRelease.' />'; +            echo '<input type="hidden" \
name="sMaintainerRating" value="'.$this->sTestedRating.'" />'; +            echo \
'<input type="hidden" name="sMaintainerRelease" value="'.$this->sTestedRelease.'" \
/>';  }
     }
 
@@ -721,7 +721,7 @@ class Version {
                 } else /* nope */
                 {
                     echo '<form method="post" name="sMessage" \
                action="maintainersubmit.php">';
-                    echo '<input type="submit" value="Be a maintainer for this app" \
class="button" title="Click here to know more about maintainers.">'; +                \
echo '<input type="submit" value="Be a Maintainer for This Version" class="button" \
                title="Click here to know more about maintainers.">';
                     echo "<input type=hidden name=\"iAppId\" \
                value=\"".$oApp->iAppId."\">";
                     echo "<input type=hidden name=\"iVersionId\" \
value=\"".$this->iVersionId."\">";  echo "</form>";
@@ -732,7 +732,7 @@ class Version {
                     {
                         echo '<form method=post name=sMessage \
                action=appview.php?iVersionId='.$this->iVersionId.'&iAppId='.$oApp->iAppId.'>';
                
                         echo '<input type=hidden name="sSub" value="StartMonitoring" \
                />';
-                        echo '<input type=submit value="Monitor Version" \
class="button" />'; +                        echo '<input type=submit value="Monitor \
Changes" class="button" />';  echo "</form>";
                     }
                 }





[prev in list] [next in list] [prev in thread] [next in thread]