[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: strange code
From:       Alexandre Julliard <julliard () winehq ! com>
Date:       2001-08-27 21:40:35
[Download RAW message or body]

Andreas Mohr <a.mohr@mailto.de> writes:

> in PROFILE_LoadWineIni(), we return from processing in case we're not
> the boot thread only *after* having created HKLM\\Software\\Wine\\Wine
> registry keys:
> 
>     if (!CLIENT_IsBootThread()) return 1;  /* already loaded */
>     
> Why ?? After all the registry is globally shared in
> wineserver, so it shouldn't be necessary to create them again
> via NtCreateKey if we're not the wine boot process.

We don't need to create the keys, but we need to create the handle to
the key. We could use NtOpenKey instead but NtCreateKey works just as
well and avoids duplicating code.

-- 
Alexandre Julliard
julliard@winehq.com

[prev in list] [next in list] [prev in thread] [next in thread]