[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] Recalculate menus after WM_INITMENU
From:       lawson_whitney () juno ! com
Date:       2001-03-17 0:23:47
[Download RAW message or body]



On Mon, 12 Mar 2001, gerard patel wrote:

> StatView (www.statview.com) menus don't work at all.
> It seems that this app recreates all submenus of the
> main menu in the WM_INITMENU handling.
>
> ChangeLog:
>
> 	* controls/menu.c
>                    Recalculate menu sizes if WM_INITMENU has recreated/changed something
>
>
Good day, Gerard!

I have noticed a couple of crashes at controls/menu.c 872 since I
applied this - when I fatfinger something in the wm (icewm) and keyboard
input gets directed to a different window, but the event comes to wine,
I think, but I haven't looked into it too closely and I'm not sure I can
reproduce it.

    /* If we get here, then it must be a text item */
    if (IS_STRING_ITEM( lpitem->fType ))
    {   SIZE size;

	GetTextExtentPoint32W(hdc, lpitem->text,  strlenW(lpitem->text), &size);

and in this case lpitem is NULL and the strlen crashes.  Would you be
interested to see traces if I can reproduce it (if so which traces)?

I think maybe it is a wm bug, but maybe wine should protect itself if it
is not too expensive to do so?

Lawson
---cut here


________________________________________________________________
GET INTERNET ACCESS FROM JUNO!
Juno offers FREE or PREMIUM Internet access for less!
Join Juno today!  For your FREE software, visit:
http://dl.www.juno.com/get/tagj.

[prev in list] [next in list] [prev in thread] [next in thread]