[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Tr: audio fix
From:       Eric Pouech <Eric.Pouech () wanadoo ! fr>
Date:       2000-08-30 18:07:36
[Download RAW message or body]

> fix nasty clicking upon device open/close by adjusting volume.
> 
> This is most probably caused by bad OS sound drivers.
> One other machine I tested doesn't have this problem.
> 
> I'll ask the developers of my sound driver (ALSA 0.5.9b for
> VIA onboard sound) ASAP to fix that.
> 
> I think it's good to have that enabled anyway
> (i.e.: #define WORKAROUND_BROKEN_DRIVERS), as I'm pretty sure it happened
> on my machine at home, too.
I don't agree.

1/ Either the fix is needed, so it's embedded in main source without
#ifdef. If it's needed on someone machine, and it's not compiled in, 
it won't be usefull at all (think rpm distribution). Fixing bug from place
A (Alsa driver) in place B (wine sound driver) seems ackward to me. Place
A needs to be fixed. This sounds a too M$ approach to me.

2/ or it's not needed. So we don't need to add it.

Do you know any Linux sound app doing the same at /dev/dsp opening ? if not
I'd be tempted to say it's option 2/
Anyway, if it's *REALLY* needed, then we should do it in all cases (or
add a registry key entry)

A+
-- 
---------------
Eric Pouech (http://perso.wanadoo.fr/eric.pouech/)
"The future will be better tomorrow", Vice President Dan Quayle

[prev in list] [next in list] [prev in thread] [next in thread]