[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: PATCH: formatmessage fix
From:       Veksler Michael <mveksler () techunix ! technion ! ac ! il>
Date:       2000-07-31 12:09:25
[Download RAW message or body]



On Mon, 31 Jul 2000, Marcus Meissner wrote:
> Changelog:
> 	added { } around stuff in ADD_TO_T macro

You forgot to add   do...while(0)   so that the macro will work inside 
if .. else block.

Index: format_msg.c
===================================================================
RCS file: /home/wine/wine/dlls/kernel/format_msg.c,v
retrieving revision 1.2
diff -u -r1.2 format_msg.c
--- format_msg.c	2000/07/29 14:35:32	1.2
+++ format_msg.c	2000/07/31 11:44:27
@@ -194,13 +194,14 @@
 	t	= target;
 	talloced= 100;

-#define ADD_TO_T(c) \
+#define ADD_TO_T(c) do { \
 	*t++=c;\
 	if (t-target == talloced) {\
 		target	= (char*)HeapReAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,target,talloced*2);\
 		t	= target+talloced;\
 		talloced*=2;\
-	}
+	}\
+} while(0)

 	if (from) {
 		f=from;

[prev in list] [next in list] [prev in thread] [next in thread]