[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: FIXME in "\window\defwnd.c"
From:       Douglas Ridgway <ridgway () winehq ! com>
Date:       2000-07-27 16:27:32
[Download RAW message or body]


I received an email questioning a patch from a few months ago. Here's the
code in question:

[ridgway@ursula windows]$ cvs diff -r 1.27 -r 1.28 defwnd.c
Index: defwnd.c
===================================================================
RCS file: /home/wine/wine/windows/defwnd.c,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -w -r1.27 -r1.28
--- defwnd.c    2000/03/28 20:23:08     1.27
+++ defwnd.c    2000/04/23 19:57:21     1.28
@@ -294,10 +294,6 @@
        /* The default action in Windows is to set the keyboard focus to
         * the window, if it's being activated and not minimized */
        if (LOWORD(wParam) != WA_INACTIVE) {
-               /* I don't know who put this SetWindowPos here, it does
not
-                * seem very logical to have it here... (FIXME?) */
-               SetWindowPos(wndPtr->hwndSelf, HWND_TOP, 0, 0, 0, 0,
-                        SWP_NOMOVE | SWP_NOSIZE);
                if (!(wndPtr->dwStyle & WS_MINIMIZE))
                        SetFocus(wndPtr->hwndSelf);
        }

Here's an email I received about it:

On Thu, 27 Jul 2000, Reece Dunn wrote:

> in the
>    case WM_ACTIVATE:
> section, the
>    SetWindowPos( wndPtr -> hwndSelf, HWND_TOP, 0, 0, 0, 0, SWP_NOMOVE |
> SWP_NOSIZE );
> line is questionmarked.
> 
> In the windows documentation on this function, it states that it alters the
> position
> (SWP_NOMOVE), the size (SWP_NOSIZE) *and* the Z-order. Therefore, this is
> perfectly
> okay, since if the window is behind another, and is then activated, this
> function
> will bring the activated window to the top of the Z-order.
> 
> -rhd-
> 
> (Reece H. Dunn)
> 

[prev in list] [next in list] [prev in thread] [next in thread]