[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: A menu patch
From:       Karl Lessard <oponvybl () umail ! corel ! com>
Date:       1999-09-29 17:32:03
[Download RAW message or body]

Hi,

I have to admit I'm a little suprised, cause the only thing that I've
change is the return value on a failure (-1 instead of 0) in
ExecFocusedItem. This method is internal to controls/menu.c, and all its
calls have been changed to proceed -1 now, which are MENU_TrackMenu and
MENU_ButtonUp. I just had another look, and I haven't found anything that
may be crashed...or maybe I'm too blind to find it :/

If you found something, contact me again

Karl



Stephane Lussier wrote:
> 
> Hi,
> 
> This patch has been committed yesterday and unfortunately it's causing
> context menu (right mouse click menu) to failed. (at least in Quattro)
> 
> Karl, do you have an idea of what's causing the problem?
> 
> Anyway, I'll take a look when I'll get time today.
> 
>         Stephane.
> 
> -----Original Message-----
> From: Karl Lessard [mailto:ybicubuk@umail.corel.com]
> Sent: Monday, September 27, 1999 1:28 PM
> To: wine-patches@winehq.com
> Subject: A menu patch
> 
> Hi,
> 
> This patch fix a little problem for ExecFocusedItem calls in
> controls/menu.c (These are all internal calls). The problem is that method
> returns the itemID if it succeeds, or 0 if it fails. But it's possible to
> have an item with 0 as its ID (that happened in my case), so I change the
> code to use -1 for a 'fail' flag instead of 0.
> 
> Thanks,
> Karl
> 
> --
> Karl Lessard
> Software engineering (Co-op) - Linux team
> Corel Corp
> karll@corel.com
> 
>   ---------------------------------------------------------------------------
>                 Name: menu.diff
>    menu.diff    Type: Plain Text (text/plain)
>             Encoding: quoted-printable

-- 
Karl Lessard
Software engineering (Co-op) - Linux team
Corel Corp
karll@corel.com
.


=========================================================================

[prev in list] [next in list] [prev in thread] [next in thread]