[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: winsock header patch #1
From:       Eric Pouech <Eric.Pouech () wanadoo ! fr>
Date:       1999-09-25 17:04:44
[Download RAW message or body]

Hi Ove, 

two points:
1/ I checked winsock2.h header, and guess what ? the values are correct :-)
2/ since those values will "pollute" the name space from winsock(1.x).h header file, 
wouldn't it be better to put them in a .h private to wine (e.g. in include/server.h, or
even a file specific to socket implementation)

just my 2 cents

A+

Ove Kaaven wrote:
> 
> These constants are documented to be used in WSAEnumNetworkEvents (which
> is only to be used in conjunction with WSAEventSelect). While I haven't
> verified the values with a real winsock2.h, what other values could they
> possibly have? I use them to transfer error state information from the
> wineserver in a way similar to WSAEnumNetworkEvents inside the service
> thread callback for WSAAsyncSelect.
> 
> Note that though I use Winsock2 stuff to implement things here, I am *not*
> implementing Winsock2. (The "service provider" concept in Winsock2 would
> readily solve Patrik's problem with BeOS though, but I don't intend to do
> that right now... maybe later, if/when I feel like adding IrDA support,
> as the IrDA stack in Windows is a Winsock2 Service Provider)
> 
> Log:
>         Added FD_*_BITS defines from Winsock2.
> 
> Index: wine/include/winsock.h
> ===================================================================
> RCS file: /home/wine/wine/include/winsock.h,v
> retrieving revision 1.20
> diff -u -r1.20 winsock.h
> --- wine/include/winsock.h      1999/07/31 17:32:06     1.20
> +++ wine/include/winsock.h      1999/09/25 16:17:20
> @@ -284,6 +284,13 @@
>  #define WS_FD_RAW         0x80000000
>  #define WS_FD_INTERNAL    0xFFFF0000
> 
> +#define FD_READ_BIT        0
> +#define FD_WRITE_BIT       1
> +#define FD_OOB_BIT         2
> +#define FD_ACCEPT_BIT      3
> +#define FD_CONNECT_BIT     4
> +#define FD_CLOSE_BIT       5
> +
>  /*
>   * All Windows Sockets error constants are biased by WSABASEERR from
>   * the "normal"

-- 
---------------
Eric Pouech (http://perso.wanadoo.fr/eric.pouech/)
"The future will be better tomorrow", Vice President Dan Quayle


=========================================================================

[prev in list] [next in list] [prev in thread] [next in thread]