[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Alexandre Julliard : shell32: Allocate a full SHITEMID to avoid a compiler warning.
From:       Eric Pouech <eric.pouech () orange ! fr>
Date:       2023-01-26 7:25:09
Message-ID: 38dff971-19e0-4197-6974-9dda2e0fa58d () orange ! fr
[Download RAW message or body]

Le 25/01/2023 à 22:22, Alexandre Julliard a écrit  :
> Module: wine
> Branch: master
> Commit: c844ebdb0ae8994ee4f3d1d3c1697ece06f52a4e
> URL:    https://gitlab.winehq.org/wine/wine/-/commit/c844ebdb0ae8994ee4f3d1d3c1697ece06f52a4e
>
> Author: Alexandre Julliard <julliard@winehq.org>
> Date:   Tue Jan 24 22:22:52 2023 +0100
>
> shell32: Allocate a full SHITEMID to avoid a compiler warning.
>
> ---
>
>   dlls/shell32/shfldr_fs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/shell32/shfldr_fs.c b/dlls/shell32/shfldr_fs.c
> index 662d8b52d5b..d47911dbef7 100644
> --- a/dlls/shell32/shfldr_fs.c
> +++ b/dlls/shell32/shfldr_fs.c
> @@ -347,7 +347,7 @@ IShellFolder_fnParseDisplayName (IShellFolder2 * iface,
>           /* Special case for the root folder. */
>           if (!wcsicmp( szPath, L"\\\\?\\unix\\" ))
>           {
> -            *ppidl = SHAlloc(sizeof(USHORT));
> +            *ppidl = SHAlloc(sizeof(*ppidl));

shouldn't it be sizeof(**ppidl) instead to better match the patch 
description?





[prev in list] [next in list] [prev in thread] [next in thread]