[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: RFC: Allow marking unreliable tests as flaky.
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2022-08-31 18:21:38
Message-ID: 87czcgz32l.fsf () wine
[Download RAW message or body]

Francois Gouget <fgouget@codeweavers.com> writes:

> On Wed, 1 Jun 2022, Rémi Bernon wrote:
> [...]
>> I think flaky_if should be enough, and then there could be some shortcut
>> global variables for `!strcmp(winetest_platform, "windows" / "wine")`, so it's
>> not too long to write.
>
>  So:       flaky_if( is_windows )
>            flaky_if( is_wine )
>  and plain flaky()

I think flaky_wine is better. I don't see a need for flaky_windows
though, there's no reason to enforce that a test should always succeed
on Wine if it doesn't on Windows.

-- 
Alexandre Julliard
julliard@winehq.org



[prev in list] [next in list] [prev in thread] [next in thread]