[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Puzzling IPrincipal:UserId check in taskschd
From:       Dmitry Timoshkov <dmitry () baikal ! ru>
Date:       2022-08-31 17:07:19
Message-ID: 20220831200719.8f744a225a4b9b0fcf201fdb () baikal ! ru
[Download RAW message or body]

Francois Gouget <fgouget@free.fr> wrote:

> I would expect all these property getters to work the same way.
> So would something like that make more sense?
> 
>     hr = IPrincipal_get_UserId(principal, &bstr);
>     if (hr == S_OK && bstr)
>     {
>         hr = write_text_value(stream, L"UserId", bstr);

I'd guess the check is supposed to avoid writing an empty UserId, and
apparently the check for bstr being NULL is not enough. I don't recall
why writing empty UserId is different from other property values.

-- 
Dmitry.


[prev in list] [next in list] [prev in thread] [next in thread]