[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 0/1] MR352: cmd: Don't loop infinitely on NUL.
From:       "eric pouech ( () epo)" <wine () gitlab ! winehq ! org>
Date:       2022-06-30 16:59:09
Message-ID: wine-wine-mr352-v1-note3065 () gitlab-mail-bridge
[Download RAW message or body]

I tested some more on my side, and it's not what I expected :-(
https://testbot.winehq.org/JobDetails.pl?Key=117992

these tests need to be extended (cannot tell which one of the two new tests display \
nothing) (likely the contents1 displays nothing and for contents2 printf doesn't \
print the ctrl-z character)

anyway, I tried also to run this simple batch on windows:
`"echo\necho\0\echo"`
and it hangs after printing the first 'echo on' (so \0 isn't a generic EOF marker)

so changing WCMD_fgets when running into \0 to return EOF isn't likely the right \
solution (at least as a generic solution) (and I still don't like in case of "abc\0" \
not returning the "abc" characters)

more tests are needed :-(

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/352#note_3065


[prev in list] [next in list] [prev in thread] [next in thread]