[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] msadpm: Stop decoding instead of crashing for invalid adpcm
From:       Eric Pouech <eric.pouech () orange ! fr>
Date:       2022-04-30 12:08:38
Message-ID: 04c8b536-fbe8-192b-41b9-9518a8a08bed () orange ! fr
[Download RAW message or body]

Le 30/04/2022 à 05:28, Moore, Brandon A. a écrit  :
Hi Brandon,

two points:
- the lines around your patch don't use tabs, please don't introduce them
- I don't see why you need to test src+1? (il you copied it from the 
other routine, it's for stereo handling, while the one you patched is 
for mono handling, hence a single adpcm coeff)

A+

[prev in list] [next in list] [prev in thread] [next in thread]