[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    [PATCH v2 3/4] msvcrt: Don't use fegetenv in nearbyint.
From:       Piotr Caban <piotr () codeweavers ! com>
Date:       2022-01-31 20:36:33
Message-ID: acb4e3fe-bf56-33fe-7e19-d161827f532c () codeweavers ! com
[Download RAW message or body]

The fegetenv/feupdateenv functions are broken in msvcr120 and are
causing unintentional SSE control word changes.

Signed-off-by: Piotr Caban <piotr@codeweavers.com>
---
  dlls/msvcrt/math.c | 22 +++++++++++++++++-----
  1 file changed, 17 insertions(+), 5 deletions(-)


["0003-msvcrt-Don-t-use-fegetenv-in-nearbyint.txt" (text/x-patch)]

diff --git a/dlls/msvcrt/math.c b/dlls/msvcrt/math.c
index b12ba3e9585..3907dc9dc94 100644
--- a/dlls/msvcrt/math.c
+++ b/dlls/msvcrt/math.c
@@ -6844,13 +6844,25 @@ double CDECL _yn(int n, double x)
  */
 double CDECL nearbyint(double x)
 {
-    fenv_t env;
+    BOOL update_cw, update_sw;
+    unsigned int cw, sw;
 
-    fegetenv(&env);
-    _control87(_MCW_EM, _MCW_EM);
+    _setfp(&cw, 0, &sw, 0);
+    update_cw = !(cw & _EM_INEXACT);
+    update_sw = !(sw & _SW_INEXACT);
+    if (update_cw)
+    {
+        cw |= _EM_INEXACT;
+        _setfp(&cw, _EM_INEXACT, NULL, 0);
+    }
     x = rint(x);
-    feclearexcept(FE_INEXACT);
-    feupdateenv(&env);
+    if (update_cw || update_sw)
+    {
+        sw = 0;
+        cw &= ~_EM_INEXACT;
+        _setfp(update_cw ? &cw : NULL, _EM_INEXACT,
+                update_sw ? &sw : NULL, _SW_INEXACT);
+    }
     return x;
 }
 



[prev in list] [next in list] [prev in thread] [next in thread]