[prev in list] [next in list] [prev in thread] [next in thread]
List: wine-devel
Subject: Re: [PATCH 2/2] wdscore: Add CurrentIP stub.
From: Mohamad Al-Jaf <mohamadaljaf () gmail ! com>
Date: 2021-12-30 0:47:29
Message-ID: CAB2hftL3AeHFH02vZPM_GWxemi=+DgGKEF0Z3X7YDCEEiY+FXA () mail ! gmail ! com
[Download RAW message or body]
Whoops, I was simultaneously thinking of "in every respect" and "in all
aspects" and mangled them together haha. I meant to say "Zebediah's method
is superior in all aspects".
On Wed, Dec 29, 2021 at 7:41 PM Mohamad Al-Jaf <mohamadaljaf@gmail.com>
wrote:
> Interesting discussion, but it looks like Zebediah's method is superior in
> all respects.
>
> I can confirm that CurrentIP takes 0 arguments. I also tested her method
> with other, documented functions, that I know the argument counts of and it
> works perfectly.
>
> On Tue, Dec 28, 2021 at 1:31 PM Zebediah Figura (she/her) <
> zfigura@codeweavers.com> wrote:
>
>> On 12/28/21 12:24, Saulius Krasuckas wrote:
>> > On 2021-12-28 18:22, Alexandre Julliard wrote:
>> >> Saulius Krasuckas <saulius2@ar-fi.lt> writes:
>> >>
>> >>> By looking at the disassembled calling points of the function and its'
>> >>> epilogues [1] _and_ by avoiding to memorize what does core of the
>> >>> function do (particularly which other WinAPI functions does it call),
>> >>> you stay safe and in compliance with copyrights and other stuff of
>> >>> Intellectual Property law.
>> >>
>> >> No, you should never look at a disassembly of a Windows dll, period.
>> >>
>> >> Please read https://wiki.winehq.org/Clean_Room_Guidelines for details.
>> >
>> > Alexandre, I have read it before my answer and I found it to be
>> > contradicting other documentation page. So I had to interpret this
>> > contradiction.
>> >
>> > Do you and other folks agree that part of the documentation is
>> > misleading or even incorrect in that regard?
>>
>> It doesn't seem clear to me whether that page advises disassembling the
>> function or its caller, but since it's ambiguous (and not particularly
>> helpful) I've just removed the entire section.
>>
>>
[Attachment #3 (text/html)]
<div dir="ltr">Whoops, I was simultaneously thinking of "in every respect" \
and "in all aspects" and mangled them together haha. I meant to say \
"Zebediah's method is superior in all aspects".</div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Dec 29, 2021 at 7:41 PM \
Mohamad Al-Jaf <<a \
href="mailto:mohamadaljaf@gmail.com">mohamadaljaf@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
dir="ltr">Interesting discussion, but it looks like Zebediah's method is \
superior in all respects.<div><br></div><div>I can confirm that CurrentIP takes 0 \
arguments. I also tested her method with other, documented functions, that I know the \
argument counts of and it works perfectly.</div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Dec 28, 2021 at 1:31 PM \
Zebediah Figura (she/her) <<a href="mailto:zfigura@codeweavers.com" \
target="_blank">zfigura@codeweavers.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">On 12/28/21 12:24, Saulius Krasuckas wrote:<br> \
> On 2021-12-28 18:22, Alexandre Julliard wrote:<br> >> Saulius Krasuckas \
<<a href="mailto:saulius2@ar-fi.lt" target="_blank">saulius2@ar-fi.lt</a>> \
writes:<br> >><br>
>>> By looking at the disassembled calling points of the function and \
its'<br> >>> epilogues [1] _and_ by avoiding to memorize what does core \
of the<br> >>> function do (particularly which other WinAPI functions does \
it call),<br> >>> you stay safe and in compliance with copyrights and other \
stuff of<br> >>> Intellectual Property law.<br>
>><br>
>> No, you should never look at a disassembly of a Windows dll, period.<br>
>><br>
>> Please read <a href="https://wiki.winehq.org/Clean_Room_Guidelines" \
rel="noreferrer" target="_blank">https://wiki.winehq.org/Clean_Room_Guidelines</a> \
for details.<br> > <br>
> Alexandre, I have read it before my answer and I found it to be <br>
> contradicting other documentation page. So I had to interpret this <br>
> contradiction.<br>
> <br>
> Do you and other folks agree that part of the documentation is <br>
> misleading or even incorrect in that regard?<br>
<br>
It doesn't seem clear to me whether that page advises disassembling the <br>
function or its caller, but since it's ambiguous (and not particularly <br>
helpful) I've just removed the entire section.<br>
<br>
</blockquote></div>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic