[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 1/8] evr/tests: Move the DirectShow filter tests to a separate file.
From:       "Zebediah Figura (she/her)" <zfigura () codeweavers ! com>
Date:       2021-10-31 22:52:18
Message-ID: 0e4ba2f6-8776-1b7d-27a0-f37c340d83b6 () codeweavers ! com
[Download RAW message or body]

On 10/31/21 16:16, Nikolay Sivov wrote:
> 
> 
> On 10/27/21 8:08 PM, Zebediah Figura wrote:
>> Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
>> ---
>>   dlls/evr/tests/Makefile.in |   3 +-
>>   dlls/evr/tests/evr.c       | 337 +-------------------------------
>>   dlls/evr/tests/filter.c    | 390 +++++++++++++++++++++++++++++++++++++
>>   3 files changed, 394 insertions(+), 336 deletions(-)
>>   create mode 100644 dlls/evr/tests/filter.c
>>
> I don't care that much, but I also don't see a point of splitting it
> like that. Same for rename in next patch.
> 

I suppose it's a difference in code style (I can't stand mfplat.c...) 
but I guess I'm willing to leave this one alone.

At the very least it can wait until more tests for the EVR filter become 
necessary.

[prev in list] [next in list] [prev in thread] [next in thread]