[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] vkd3d-shader: Fix array size for dimension strings
From:       Giovanni Mascellani <gmascellani () codeweavers ! com>
Date:       2021-10-30 18:36:14
Message-ID: 23875403-4c51-90f6-1a13-2f9ed7c6c25b () codeweavers ! com
[Download RAW message or body]

Signed-off-by: Giovanni Mascellani <gmascellani@codeweavers.com>
--
I noticed that too, and it was for the same reason... :-P

I think we tend to use "vkd3d-shader/hlsl" in the patch subject in cases 
like this, but I don't think that's too important.

On 30/10/21 02:56, Joshua Ashton wrote:
> Encountered this while I was messing around adding 2DMS support.
> 
> Signed-off-by: Joshua Ashton <joshua@froggi.es>
> ---
>   libs/vkd3d-shader/hlsl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c
> index 9bce6be..82c021a 100644
> --- a/libs/vkd3d-shader/hlsl.c
> +++ b/libs/vkd3d-shader/hlsl.c
> @@ -911,7 +911,7 @@ struct vkd3d_string_buffer *hlsl_type_to_string(struct hlsl_ctx *ctx, const stru
>   
>           case HLSL_CLASS_OBJECT:
>           {
> -            static const char dimensions[5][HLSL_SAMPLER_DIM_MAX + 1] =
> +            static const char dimensions[HLSL_SAMPLER_DIM_MAX + 1][5] =
>               {
>                   [HLSL_SAMPLER_DIM_1D] = "1D",
>                   [HLSL_SAMPLER_DIM_2D] = "2D",
> 

[prev in list] [next in list] [prev in thread] [next in thread]