[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    [PATCH] mscoree: Don't trace arguments in CorExeMain.
From:       Esme Povirk <esme () codeweavers ! com>
Date:       2021-08-31 18:25:32
Message-ID: 20210831182532.1893013-1-esme () codeweavers ! com
[Download RAW message or body]

This can overflow the debug buffer. We could print each argument
on an individual line, but command-line arguments can be
obtained other ways and turned out to usually not be useful.

Signed-off-by: Esme Povirk <esme@codeweavers.com>
---
The argc trace is added so I don't get confused about whether
logs are from a verion of Wine that traces arguments or not.

The filename trace is kept because it's very convenient for the
+mscoree trace to show every managed PE image loaded in the process.

 dlls/mscoree/corruntimehost.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/dlls/mscoree/corruntimehost.c b/dlls/mscoree/corruntimehost.c
index 51522c57d83..c4dfbe88b99 100644
--- a/dlls/mscoree/corruntimehost.c
+++ b/dlls/mscoree/corruntimehost.c
@@ -1449,10 +1449,7 @@ __int32 WINAPI _CorExeMain(void)
 
     GetModuleFileNameW(NULL, filename, MAX_PATH);
 
-    TRACE("%s", debugstr_w(filename));
-    for (i=0; i<argc; i++)
-        TRACE(" %s", debugstr_a(argv[i]));
-    TRACE("\n");
+    TRACE("%s argc=%i\n", debugstr_w(filename), argc);
 
     filenameA = WtoA(filename);
     if (!filenameA)
-- 
2.30.2


[prev in list] [next in list] [prev in thread] [next in thread]