[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] wined3d: Negiotiate less specific memory types on allocation failure.
From:       Jan Sikorski <jsikorski () codeweavers ! com>
Date:       2021-07-30 9:24:28
Message-ID: 9A2D5CA4-3A8F-4F12-8173-8A35DD25C3D1 () codeweavers ! com
[Download RAW message or body]


> On 29 Jul 2021, at 18:36, Zebediah Figura (she/her) <zfigura@codeweavers.com> \
> wrote: 
> This will still spew an ERR message, though, which seems less than ideal.

Maybe "Failed to find a suitable memory type" could be a WARN instead? I think other \
failures could stay ERR. I'd upgrade to an ERR at the call site as well.

> Also, the while loop seems awkward to me, couldn't we instead do something like \
> (abbreviated): 
> if (!wined3d_context_vk_create_bo(memory_type)
> && !wined3d_context_vk_create_bo(memory_type & ~HOST_CACHED)
> && !wined3d_context_vk_create_bo(memory_type & ~DEVICE_LOCAL))

Yeah, it isn't exactly equivalent (the loop could go DCV -> DV -> VC -> V), but I \
guess the last step isn't helping much. I'll do the simplified thing in v2.

- Jan


[prev in list] [next in list] [prev in thread] [next in thread]