[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH v2 7/7] wined3d: No longer export wined3d_device_set_render_state().
From:       Henri Verbeet <hverbeet () gmail ! com>
Date:       2021-04-30 17:00:27
Message-ID: CAOsNvwxtQTGtSo6ioMDGw_txq5yE2uBST+MxgDpUs6JNOWSGsA () mail ! gmail ! com
[Download RAW message or body]

On Fri, 30 Apr 2021 at 18:09, Zebediah Figura <z.figura12@gmail.com> wrote:
> -void CDECL wined3d_device_set_render_state(struct wined3d_device *device,
> +static void wined3d_device_set_render_state(struct wined3d_device *device,
> enum wined3d_render_state state, DWORD value)
> {
> -    TRACE("device %p, state %s (%#x), value %#x.\n", device, \
>                 debug_d3drenderstate(state), state, value);
> -
> if (state > WINEHIGHEST_RENDER_STATE)
> {
> WARN("Unhandled render state %#x.\n", state);

Arguably the TRACE is still somewhat useful, but if you're removing
things, note that both the bounds check on "state" and the special
handling for WINED3D_RS_POINTSIZE are superfluous now.


[prev in list] [next in list] [prev in thread] [next in thread]