[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] conhost: Fix wrapping when write_console finishes on line end.
From:       Gabriel_Ivăncescu <gabrielopcode () gmail ! com>
Date:       2021-03-31 15:24:08
Message-ID: d48f6520-c875-a4e9-e438-d1ea8d9d85a0 () gmail ! com
[Download RAW message or body]

On 31/03/2021 15:27, Jacek Caban wrote:
> On 3/31/21 1:42 PM, Gabriel Ivăncescu wrote:
>> This makes it pass on Windows, since it always outputs a newline 
>> immediately and never a backspace. In fact, removing the condition at 
>> all will *still* pass on Windows. So this condition is there for Wine? 
>> Is there a reason for it? And what should I keep in mind here to solve 
>> this "properly"?
>>
>> If you remove the condition, of course wine will fail the tests, but 
>> Windows won't. I really don't understand it.
> 
> Windows behavior isn't consistent between versions here. When I wrote 
> those tests it was a relatively fresh feature and its output changed 
> between Windows updates. Tests were written in a way that would accept 
> all of them. Hopefully things have matured now and it's good that 
> behavior of recent versions is better. We should follow that and 
> probably even mark those '\b' code paths as broken.
> 
> Jacek

Ok so it looks like it does add a \b sometimes, but not during the tests 
I added because I added them after setting the output mode. I'm guessing 
the default output mode has some "delayed newline" flag and that differs 
between versions. I'll have to look into it.

[prev in list] [next in list] [prev in thread] [next in thread]