[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH V3 2/2] msxml3: Implement SAXContentHandler methods for DOMDocument mxwriter output.
From:       Nikolay Sivov <bunglehead () gmail ! com>
Date:       2021-02-27 11:02:36
Message-ID: CAG4Z_JJeKhhyxp8XtYGOHbh+f=he-+19Z4whQGLs2MeJbuRuYw () mail ! gmail ! com
[Download RAW message or body]

On Sat, Feb 27, 2021 at 11:30 AM Jefferson Carpenter <
jeffersoncarpenter2@gmail.com> wrote:

> I guess another possibility would be to write two vtables: one for
> IStream and String, and another for IDOMDocumnt, and assign the vtable
> during put_output.
>
> (I'm half joking, it would run properly but swapping out vtables is not
> something I've ever heard of)
>

Yes, that would be better. You don't need to swap actual interface vtables,
you'll need to come up with a set of functions
that would be called internally from SAX methods, and then you can have
multiple implementations of those.


>
> thanks,
> Jefferson
>
> On 2/26/2021 10:49 PM, Jefferson Carpenter wrote:
> > nsivov,
> >
> > Regarding implementation in mxwriter, do you think it would be all right
> > to add switch statements and use an enum for output type like I did
> > here, or do you think another way would be more suitable?
> >
> > Thanks,
> > Jefferson
>

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Sat, Feb 27, 2021 at 11:30 AM Jefferson Carpenter &lt;<a \
href="mailto:jeffersoncarpenter2@gmail.com">jeffersoncarpenter2@gmail.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I guess another \
possibility would be to write two vtables: one for <br> IStream and String, and \
another for IDOMDocumnt, and assign the vtable <br> during put_output.<br>
<br>
(I&#39;m half joking, it would run properly but swapping out vtables is not <br>
something I&#39;ve ever heard of)<br></blockquote><div><br></div><div>Yes, that would \
be better. You don&#39;t need to swap actual interface vtables, you&#39;ll need to \
come up with a set of functions</div><div>that would be called internally from SAX \
methods, and then you can have multiple implementations of those.</div><div>  \
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px \
solid rgb(204,204,204);padding-left:1ex"> <br>
thanks,<br>
Jefferson<br>
<br>
On 2/26/2021 10:49 PM, Jefferson Carpenter wrote:<br>
&gt; nsivov,<br>
&gt; <br>
&gt; Regarding implementation in mxwriter, do you think it would be all right <br>
&gt; to add switch statements and use an enum for output type like I did <br>
&gt; here, or do you think another way would be more suitable?<br>
&gt; <br>
&gt; Thanks,<br>
&gt; Jefferson<br>
</blockquote></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]