[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH v8] gdi32/tests: Add tests for the advanced graphics mode
From:       Ralf Habacker <ralf.habacker () freenet ! de>
Date:       2021-02-16 15:57:12
Message-ID: ef5b421a-f60b-7e4b-6d48-e57e458b213f () freenet ! de
[Download RAW message or body]


Am 10.02.21 um 11:40 schrieb Huw Davies:
> On Wed, Feb 10, 2021 at 11:02:49AM +0100, Ralf Habacker wrote:
>> The tests are designed to support an automated mode and an interactive
>> mode.
>>
>> In automated mode, only tests where the angle used is a multiple of pi/4
>> are performed to increase the chance of matching images created on Windows.
>>
>> In interactive test mode, an image is generated for each test for visual
>> verification.
> 
> Do you have plans to work on the implementation fixes?

yes

> It's probably better to start with that and then write specific
> tests that are easy to get the implementation correct for.

I have a working patch, which fixes issues for Arc, Chord, Ellipse and
Pie (see appended screenshots)

> Adding random tests at this point will likely make the fixing
> the implementation harder

I removed all not working tests from the automatic mode with v9.

Ralf

["gdi32-dib-advanced-current.png" (image/png)]
["gdi32-dib-advanced-with-patch.png" (image/png)]

[prev in list] [next in list] [prev in thread] [next in thread]