[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH v2] gdi32/tests: Add tests for the advanced graphics mode
From:       Nikolay Sivov <nsivov () codeweavers ! com>
Date:       2021-02-09 8:22:26
Message-ID: f9cf2eca-4693-4590-d316-bff9d0da6263 () codeweavers ! com
[Download RAW message or body]



On 2/9/21 11:17 AM, Ralf Habacker wrote:
> +void check_hash( test_data *td )
> +{
> +#ifdef WITH_HASH
> +    if ( td->hash_dib )
> +        HeapFree( GetProcessHeap(), 0, td->hash_dib );
> +    td->hash_dib = hash_dib( td->dc, td->bmi, td->bits );
> +    printf( "const char *%s = \"%s\";\n", td->hash_name, td->hash_dib );
> +#endif
> +    // instead we dump the display to a file for visual inspection
> +    save_bitmap_to_file( td->dib, td->save_path );
> +}
Does it mean that new tests don't really check any output, because
WITH_HASH is not set? If so, what's a point of having them running
automated with other tests?

[prev in list] [next in list] [prev in thread] [next in thread]