[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] conhost: Respect the StartupInfo's wShowWindow.
From:       Dmitry Timoshkov <dmitry () baikal ! ru>
Date:       2020-11-30 16:39:23
Message-ID: 20201130193923.a63f06482dd778478a76bb59 () baikal ! ru
[Download RAW message or body]

Gabriel Ivăncescu <gabrielopcode@gmail.com> wrote:

> > > -        ShowWindow( console.win, SW_SHOW );
> > > +        ShowWindow( console.win, (si.dwFlags & STARTF_USESHOWWINDOW) && \
> > > si.wShowWindow != SW_SHOWDEFAULT +                                 ? \
> > > si.wShowWindow : SW_SHOW );
> > 
> > What's the reason to treat SW_SHOWDEFAULT specially?
> > 
> 
> I initially tried just setting it to SW_SHOWDEFAULT without any checks, 
> and it didn't work. I was assuming the SW_SHOW was there for a reason in 
> such case, as the "default". I'm not that familiar with how this works, 
> so of course I can remove it if it's actually unnecessary.

If there's no real reason then please remove it.

-- 
Dmitry.


[prev in list] [next in list] [prev in thread] [next in thread]