[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 1/3] ntdll: Update the PEB structures for newer Windows versions.
From:       Brendan Shanks <bshanks () codeweavers ! com>
Date:       2020-10-30 15:15:21
Message-ID: FE2F5490-93AF-442B-8680-649F98F4810F () codeweavers ! com
[Download RAW message or body]

> On Oct 30, 2020, at 6:09 AM, Gabriel Ivăncescu <gabrielopcode@gmail.com> wrote:
> 
> On 30/10/2020 09:20, Brendan Shanks wrote:
>> Signed-off-by: Brendan Shanks <bshanks@codeweavers.com>
>> ---
>>  include/winternl.h | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>> diff --git a/include/winternl.h b/include/winternl.h
>> index bd6a2c35932..1b69846cc2c 100644
>> --- a/include/winternl.h
>> +++ b/include/winternl.h
>> @@ -379,6 +379,12 @@ typedef struct _PEB
>>      PVOID                        WaitOnAddressHashTable [0x80];     /* 25c/3a0 */
>>      PVOID                        TelemetryCoverageHeader;           /* 45c/7a0 */
>>      ULONG                        CloudFileFlags;                    /* 460/7a8 */
>> +    ULONG                        CloudFileDiagFlags;                /* 464/7ac */
>> +    CHAR                         PlaceholderCompatibilityMode;      /* 468/7b0 */
>> +    ULONG                        PlaceholderCompatibilityModeReserved[7]; /* 469/7b1 */
>> +    PVOID                        LeapSecondData;                    /* 470/7b8 */
>> +    ULONG                        LeapSecondFlags;                   /* 474/7c0 */
>> +    ULONG                        NtGlobalFlag2;                     /* 478/7c4 */
>>  } PEB, *PPEB;
>>    @@ -617,6 +623,12 @@ typedef struct _PEB64
>>      ULONG64                      WaitOnAddressHashTable [0x80];     /* 03a0 */
>>      ULONG64                      TelemetryCoverageHeader;           /* 07a0 */
>>      ULONG                        CloudFileFlags;                    /* 07a8 */
>> +    ULONG                        CloudFileDiagFlags;                /* 07ac */
>> +    CHAR                         PlaceholderCompatibilityMode;      /* 07b0 */
>> +    ULONG                        PlaceholderCompatibilityModeReserved[7]; /* 07b1 */
>> +    PVOID                        LeapSecondData;                    /* 07b8 */
>> +    ULONG                        LeapSecondFlags;                   /* 07c0 */
>> +    ULONG                        NtGlobalFlag2;                     /* 07c4 */
>>  } PEB64;
>>    typedef struct _TEB64
> 
> Isn't PlaceholderCompatibilityModeReserved[7] supposed to be CHAR or BYTE?

Yes you're right, good catch. I'll send another version.

Brendan
[Attachment #3 (unknown)]

<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" \
class=""><div class="">On Oct 30, 2020, at 6:09 AM, Gabriel Ivăncescu &lt;<a \
href="mailto:gabrielopcode@gmail.com" class="">gabrielopcode@gmail.com</a>&gt; \
wrote:</div><br class="Apple-interchange-newline"><div class=""><span \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; \
float: none; display: inline !important;" class="">On 30/10/2020 09:20, Brendan \
Shanks wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration: none;" class=""><blockquote type="cite" style="font-family: \
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; \
font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; \
text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; \
text-decoration: none;" class="">Signed-off-by: Brendan Shanks &lt;<a \
href="mailto:bshanks@codeweavers.com" class="">bshanks@codeweavers.com</a>&gt;<br \
class="">---<br class="">&nbsp;include/winternl.h | 12 ++++++++++++<br \
class="">&nbsp;1 file changed, 12 insertions(+)<br class="">diff --git \
a/include/winternl.h b/include/winternl.h<br class="">index bd6a2c35932..1b69846cc2c \
100644<br class="">--- a/include/winternl.h<br class="">+++ b/include/winternl.h<br \
class="">@@ -379,6 +379,12 @@ typedef struct _PEB<br \
class="">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;PVOID \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;WaitOnAddressHashTable \
[0x80]; &nbsp;&nbsp;&nbsp;&nbsp;/* 25c/3a0 */<br \
class="">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;PVOID \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;TelemetryCoverageHeader; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* 45c/7a0 */<br \
class="">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;ULONG \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;CloudFileFlags; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* \
460/7a8 */<br class="">+ &nbsp;&nbsp;&nbsp;ULONG \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;CloudFileDiagFlags; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* \
464/7ac */<br class="">+ &nbsp;&nbsp;&nbsp;CHAR \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n \
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;PlaceholderCompatibilityMode; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* 468/7b0 */<br class="">+ &nbsp;&nbsp;&nbsp;ULONG \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n \
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;PlaceholderCompatibilityModeReserved[7]; \
/* 469/7b1 */<br class="">+ &nbsp;&nbsp;&nbsp;PVOID \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;LeapSecondData; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* \
470/7b8 */<br class="">+ &nbsp;&nbsp;&nbsp;ULONG \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;LeapSecondFlags; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* \
474/7c0 */<br class="">+ &nbsp;&nbsp;&nbsp;ULONG \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;NtGlobalFlag2; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* \
478/7c4 */<br class="">&nbsp;} PEB, *PPEB;<br class="">&nbsp;&nbsp;&nbsp;@@ -617,6 \
+623,12 @@ typedef struct _PEB64<br class="">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;ULONG64 \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;WaitOnAddressHashTable \
[0x80]; &nbsp;&nbsp;&nbsp;&nbsp;/* 03a0 */<br \
class="">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;ULONG64 \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;TelemetryCoverageHeader; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* 07a0 */<br \
class="">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;ULONG \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;CloudFileFlags; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* \
07a8 */<br class="">+ &nbsp;&nbsp;&nbsp;ULONG \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;CloudFileDiagFlags; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* \
07ac */<br class="">+ &nbsp;&nbsp;&nbsp;CHAR \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n \
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;PlaceholderCompatibilityMode; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* 07b0 */<br class="">+ &nbsp;&nbsp;&nbsp;ULONG \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n \
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;PlaceholderCompatibilityModeReserved[7]; \
/* 07b1 */<br class="">+ &nbsp;&nbsp;&nbsp;PVOID \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;LeapSecondData; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* \
07b8 */<br class="">+ &nbsp;&nbsp;&nbsp;ULONG \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;LeapSecondFlags; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* \
07c0 */<br class="">+ &nbsp;&nbsp;&nbsp;ULONG \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;NtGlobalFlag2; \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;/* \
07c4 */<br class="">&nbsp;} PEB64;<br class="">&nbsp;&nbsp;&nbsp;typedef struct \
_TEB64<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: \
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; \
font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; \
text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; \
float: none; display: inline !important;" class="">Isn't \
PlaceholderCompatibilityModeReserved[7] supposed to be CHAR or \
BYTE?</span></div></blockquote></div><br class=""><div class="">Yes you're right, \
good catch. I'll send another version.</div><div class=""><br class=""></div><div \
class="">Brendan</div></body></html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic