[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    [PATCH 1/1] wininet: Ensure ssl_ctx are empty in case of error
From:       Roberto Pungartnik <rpungartnik () gmail ! com>
Date:       2019-10-31 22:16:42
Message-ID: CAFK+GZ-Wcddo-udwFhcq2Q44R6OEka1=Y6Snw52P_3CYDvGtkA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]



[Attachment #5 (text/html)]

<div dir="ltr"><br></div>

["0001-wininet-Ensure-ssl_ctx-are-empty-in-case-of-error.patch" (text/x-patch)]

wininet: Ensure ssl_ctx are empty in case of error

If netcon_secure_connect_setup() could not configure a secure connection, it causes a \
crash in InternetQueryOptionW() during tests

Signed-off-by: Roberto Pungartnik <rpungartnik@gmail.com>
---
 dlls/wininet/netconnection.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dlls/wininet/netconnection.c b/dlls/wininet/netconnection.c
index 615a43c2be..0c8a424e09 100644
--- a/dlls/wininet/netconnection.c
+++ b/dlls/wininet/netconnection.c
@@ -452,7 +452,13 @@ static DWORD netcon_secure_connect_setup(netconn_t *connection, \
                BOOL compat_mode
         |ISC_REQ_SEQUENCE_DETECT|ISC_REQ_REPLAY_DETECT|ISC_REQ_MANUAL_CRED_VALIDATION;
  
     if(!ensure_cred_handle())
+    {
+/*        memset(&ctx, 0, sizeof(CtxtHandle));
+        if(SecIsValidHandle(&connection->ssl_ctx))
+            DeleteSecurityContext(&connection->ssl_ctx);
+        connection->ssl_ctx=ctx;*/
         return ERROR_INTERNET_SECURITY_CHANNEL_ERROR;
+    }
 
     if(compat_mode) {
         if(!have_compat_cred_handle)
-- 
2.17.1



[prev in list] [next in list] [prev in thread] [next in thread]