[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 1/6] vkd3d: Enable MSVC to compile.
From:       Henri Verbeet <hverbeet () gmail ! com>
Date:       2019-09-30 19:51:49
Message-ID: CAOsNvwwn6ZExmNmROwhBz3GWOGJ6iY2CfXB7hs9anxT3_pDHwQ () mail ! gmail ! com
[Download RAW message or body]

Hi Hans-Kristian,

From a cursory look, most of this seems fine, but see what Chip said
about e.g. vkd3d_log2i(). Could you please split this into individual
patches though? Both in order to make it more reviewable and to get
more useful bisects. Wrt. the pthread wrappers, it seems tempting to
introduce internal functions along the lines of vkd3d_create_thread(),
vkd3d_join_thread(), etc.

Henri

[prev in list] [next in list] [prev in thread] [next in thread]