[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH v2 3/3] msscript.ocx/tests: Add tests for IScriptControl::Run.
From:       Gabriel_Ivăncescu <gabrielopcode () gmail ! com>
Date:       2019-09-30 15:37:17
Message-ID: 0017027b-31e7-4b2a-8e62-4e9a383ab044 () gmail ! com
[Download RAW message or body]

On 9/30/19 5:38 PM, Jacek Caban wrote:
> Hi Gabriel,
> 
> On 9/30/19 2:43 PM, Gabriel Ivăncescu wrote:
>>          {
>> +            if (!lstrcmpW(V_BSTR(pDispParams->rgvarg), L"change me"))
>> +            {
>> +                /* Change the string to check whether it's copied or 
>> not */
>> +                lstrcpyW(V_BSTR(pDispParams->rgvarg), L"changed");
>> +            }
>> +            else
>> +                ok(!lstrcmpW(V_BSTR(pDispParams->rgvarg), L"changed"),
>> +                    "unexpected second parameter %s.\n", 
>> wine_dbgstr_w(V_BSTR(pDispParams->rgvarg)));
>> +        }
>> +        else
>> +            ok(0, "unexpected non-string second parameter V_VT = 
>> %d.\n", V_VT(pDispParams->rgvarg));
> 
> 
> While I can see why it was interesting for your experimentations, this 
> is not really nice nor something that seems important to have in tests. 
> But please remove this part. The rest of the patch looks good.
> 
> 
> Thanks,
> 
> Jacek
> 

Ok, I will resend it tomorrow after the others committed so it succeeds. :-)

[prev in list] [next in list] [prev in thread] [next in thread]