[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Fwd: [PATCH] systray: Hide systray for fullscreen games
From:       Hamish Claxton <hamishclaxton () gmail ! com>
Date:       2018-12-29 23:28:58
Message-ID: CAK8e6-AtA7cn5cw=kQrO-uS-LNDu-bqD54j00LDGN--dvHNcHw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi Fabian,

The patch I sent in actually fixes the issue, I would not send in an
untested patch.

I have just done some more digging, and you are right yes.
If it wasn't working, then the systray would be showing, as 0x1 is less
than whatever resolution you are using.

Just about to submit a v2 patch, which solves this and is actually smaller
by just calling GetSystemMetrics with SM_CXSCREEN, SM_CYSCREEN,
SM_CXFULLSCREEN & SM_CYFULLSCREEN.

Thanks in Advance,
Hamish

On Sun, Dec 30, 2018 at 8:51 AM Fabian Maurer <dark.shadow4@web.de> wrote:

> Hi Hamish,
>
>
>
> SM_CXSCREEN and SM_CYSCREEN are constants, defined as 0 respective 1.
>
>
>
> So basically your code is
>
>
>
> > if ( !( window.right >= 0 && window.bottom >= 1 ) )
>
> > do_show_systray();
>
>
>
> And this is not correct. Those values are just flags to use in the
> GetSystemMetrics function.
>
> Did you check that the patch you sent in actually fixes the issue? Or did
> you only test with a previous version of your patch? Because I don't see
> how this would help.
>
>
>
> Regards,
>
> Fabian Maurer
>

[Attachment #5 (text/html)]

<div dir="ltr">Hi Fabian,<div><br></div><div>The patch I sent in actually fixes the \
issue, I would not send in an untested patch.</div><div><br></div><div>I have just \
done some more digging, and you are right yes.  </div><div>If it wasn&#39;t working, \
then the systray would be showing, as 0x1 is less than whatever resolution you are \
using.</div><div><br></div><div>Just about to submit a v2 patch, which solves this \
and is actually smaller by just calling GetSystemMetrics with SM_CXSCREEN, \
SM_CYSCREEN, SM_CXFULLSCREEN &amp; SM_CYFULLSCREEN.</div><div><br></div><div>Thanks \
in Advance,</div><div>Hamish</div></div><br><div class="gmail_quote"><div \
dir="ltr">On Sun, Dec 30, 2018 at 8:51 AM Fabian Maurer &lt;<a \
href="mailto:dark.shadow4@web.de">dark.shadow4@web.de</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u> <div \
style="font-family:&quot;Noto \
Sans&quot;;font-size:9pt;font-weight:400;font-style:normal"> <p \
style="margin:0px;text-indent:0px">Hi Hamish,</p> <p \
style="margin:0px;text-indent:0px">  </p> <p \
style="margin:0px;text-indent:0px">SM_CXSCREEN and SM_CYSCREEN are constants, defined \
as 0 respective 1.</p> <p style="margin:0px;text-indent:0px">  </p>
<p style="margin:0px;text-indent:0px">So basically your code is</p>
<p style="margin:0px;text-indent:0px">  </p>
<p style="margin:0px;text-indent:0px">&gt;  if ( !( window.right &gt;= 0 &amp;&amp; \
window.bottom &gt;= 1 ) )</p> <p style="margin:0px;text-indent:0px">&gt;          \
do_show_systray();</p> <p style="margin:0px;text-indent:0px">  </p>
<p style="margin:0px;text-indent:0px">And this is not correct. Those values are just \
flags to use in the GetSystemMetrics function.</p> <p \
style="margin:0px;text-indent:0px">Did you check that the patch you sent in actually \
fixes the issue? Or did you only test with a previous version of your patch? Because \
I don&#39;t see how this would help.</p> <p style="margin:0px;text-indent:0px">  </p>
<p style="margin:0px;text-indent:0px">Regards,</p>
<p style="margin:0px;text-indent:0px">Fabian Maurer</p></div></blockquote></div>


[Attachment #6 (text/plain)]




[prev in list] [next in list] [prev in thread] [next in thread]