[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] kernel32: CreateDirectory shouldn't return ERROR_ACCESS_DENIED for the root of the drive
From:       Mathew Hodson <mathew.hodson () gmail ! com>
Date:       2018-12-28 23:25:18
Message-ID: CAN4in9Zy5-ZcbHCn+5tRusf_i-BvEthEigMP7SNoGPCQHyNL6Q () mail ! gmail ! com
[Download RAW message or body]

On Tue, 11 Dec 2018 at 13:13, Dmitry Timoshkov <dmitry@baikal.ru> wrote:
> > > > > I'd guess if the CreateDirectory("C:\") returns ERROR_ACCESS_DENIED
> > > > > then the app would fail. It's not clear how the VMs are configured
> > > > > and why I don't get ERROR_ACCESS_DENIED on real hardware under a not
> > > > > admin account, but it should be pretty obvious that since Wine doesn't
> > > > > perform any real administrator access checks, and if it would the checks
> > > > > should be done on the server side, ntdll checks shouldn't return access
> > > > > denied error.
> > > >
> > > > It's also pretty obvious that this check was added for a reason, so it
> > > > would need a more convincing argument to remove it.
> > >
> > > Do you recall the reason why that check was added? I can't find any
> > > specific test case for this behaviour either.
> >
> > As far as I can tell, you added it ;-)
> >
> > https://source.winehq.org/git/wine.git/commit/d75aed2c92435e8ae4d5c260e31e815ee77db34b
>
> This doesn't look right, especially without any reasonable explanation.
> Considering that now we have an application that depends on this, can
> that change be reverted?

I also found this commit, which adds the check as it most recently
existed. https://source.winehq.org/git/wine.git/commitdiff/cf67839bc4094678772858727bdfe2d596618bf0



[prev in list] [next in list] [prev in thread] [next in thread]