[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    [PATCH] testbot/web: Simplify FormPage::GetDisplayValue().
From:       Francois Gouget <fgouget () codeweavers ! com>
Date:       2018-11-30 11:55:15
Message-ID: E1gShO7-0003qa-Fa () amboise
[Download RAW message or body]

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
---
 testbot/lib/ObjectModel/CGI/FormPage.pm | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm
index 01f7894891..735755f3cf 100644
--- a/testbot/lib/ObjectModel/CGI/FormPage.pm
+++ b/testbot/lib/ObjectModel/CGI/FormPage.pm
@@ -189,12 +189,8 @@ sub GetDisplayValue($$)
 {
   my ($self, $PropertyDescriptor) = @_;
 
-  my $Value;
-  if (defined($self->GetParam($PropertyDescriptor->GetName())))
-  {
-    $Value = $self->GetParam($PropertyDescriptor->GetName());
-  }
-  else
+  my $Value = $self->GetParam($PropertyDescriptor->GetName());
+  if (!defined $Value)
   {
     $Value = $self->GetPropertyValue($PropertyDescriptor);
   }
-- 
2.19.1



[prev in list] [next in list] [prev in thread] [next in thread]