[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] wincodecs: Add IWICImagingFactory2 stub.
From:       Dmitry Timoshkov <dmitry () baikal ! ru>
Date:       2018-09-30 8:45:49
Message-ID: 20180930164549.d0b511337ad6e63440a82f9c () baikal ! ru
[Download RAW message or body]

Nikolay Sivov <nsivov@codeweavers.com> wrote:

> >>>>    typedef struct {
> >>>>        IWICComponentFactory IWICComponentFactory_iface;
> >>>> +    IWICImagingFactory2 IWICImagingFactory2_iface;
> >>>>        LONG ref;
> >>>>    } ComponentFactory;
> >>> IWICImagingFactory2 just extends IWICImagingFactory by one element, this
> >>> approach seems to be a bit strange.
> >>>
> >> Both IWICComponentFactory andIWICImagingFactory2extend IWICImagingFactory.
> > If you mean that you have to choose which one should use IWICImagingFactory
> > as a base class then an obvious choice would be IWICImagingFactory2. If you
> > ment something else please try to be less cryptic in your responses.
> >
> If you mean it's better to move existing IWICImagingFactory methods 
> implementation to newly added IWICImagingFactory2, I don't think it's 
> obvious or necessary. It will lead to larger diff without any functional 
> impact. Structure was unfortunately renamed from ImagingFactory, but 
> well what's done is done.

Yes, that's a little bit unfortunate, but IMO it's a good opportunity
to fix it now while moving to a newer version of the interface instead
of keeping this mess forever.

-- 
Dmitry.



[prev in list] [next in list] [prev in thread] [next in thread]