[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 2/2] wininet: Add support for INTERNET_OPTION_SETTINGS_CHANGED in InternetSetOption.
From:       Jacek Caban <jacek () codeweavers ! com>
Date:       2018-04-30 15:37:31
Message-ID: f5aec5cd-7aee-8b33-65a9-2a85b9de2594 () codeweavers ! com
[Download RAW message or body]

Hi Alistair,

On 04/30/2018 03:00 AM, Alistair Leslie-Hughes wrote:
> +    ret = InternetSetOptionA(ses, INTERNET_OPTION_REFRESH, NULL, 0);
> +    ok(ret == TRUE, "InternetSetOption should've succeeded\n");
> +
> +    SetLastError(0xdeadbeef);
> +    ret = InternetSetOptionA(req, INTERNET_OPTION_REFRESH, NULL, 0);
> +    todo_wine ok(ret == FALSE, "InternetSetOption should've failed\n");
> +    todo_wine ok(GetLastError() == ERROR_INTERNET_INCORRECT_HANDLE_TYPE, \
> "GetLastError() = %x\n", GetLastError());


Given those tests, I think the implementation should go to
HTTPSESSION_SetOption instead.


Thanks,

Jacek


[prev in list] [next in list] [prev in thread] [next in thread]