[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 5/6] d2d1: Introduce a helper function to allocate arrays.
From:       Henri Verbeet <hverbeet () gmail ! com>
Date:       2018-01-31 19:21:52
Message-ID: CAOsNvwygcekDkNY+h+6Zkfe1HjbqsrZ++SQguB_wzUP5gGigiQ () mail ! gmail ! com
[Download RAW message or body]

On 31 January 2018 at 22:02, Michael Stefaniuc <mstefani@winehq.org> wrote:
> On 01/31/2018 04:19 PM, Henri Verbeet wrote:
>> diff --git a/dlls/d2d1/d2d1_private.h b/dlls/d2d1/d2d1_private.h
>> index caeb4b9..2c10252 100644
>> --- a/dlls/d2d1/d2d1_private.h
>> +++ b/dlls/d2d1/d2d1_private.h
>> @@ -477,6 +477,15 @@ void d2d_transformed_geometry_init(struct d2d_geometry *geometry, ID2D1Factory *
>>          ID2D1Geometry *src_geometry, const D2D_MATRIX_3X2_F *transform) DECLSPEC_HIDDEN;
>>  struct d2d_geometry *unsafe_impl_from_ID2D1Geometry(ID2D1Geometry *iface) DECLSPEC_HIDDEN;
>>
>> +static inline void *d2d_calloc(size_t count, size_t size)
> Why don't you just add this as heap_calloc() to heap.h?
> That function wasn't controversial in my initial patch.
>
I'd be happy to, if that's preferred.

> I see it doesn't zero the memory but I'm fine with that. We can have a
> heap_calloc_zero() too for those that need it.
>
It doesn't matter for this patch, but that was an oversight.



[prev in list] [next in list] [prev in thread] [next in thread]