[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 3/4] dx8vb: Add Direct3D8 interface with stubs
From:       Fabian Maurer <dark.shadow4 () web ! de>
Date:       2017-10-31 1:31:14
Message-ID: 2254454.1R8L0zzGXG () arch
[Download RAW message or body]

> > 
> > -    FIXME("(%p): stub!\n", ret);
> > +    HRESULT res = direct3d8_create(ret);
> > 
> > -    return E_NOTIMPL;
> > +    TRACE("(%p) -> (%x)\n", ret, res);
> > +
> > +    return res;
> > 
> >  }
> 
> That's an unusual way to arrange things. Why don't you return as "return
> direct3d8_create();" ?

I did this so I can trace the return value. Since it's a wrapper with nearly 
no own code I figured it makes sense. Is this unneeded? Because if so, I'll 
change that.

Regards,
Fabian Maurer



[prev in list] [next in list] [prev in thread] [next in thread]