[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] ddraw/tests: Avoid dereferencing a null pointer in case of failure.
From:       Henri Verbeet <hverbeet () gmail ! com>
Date:       2017-10-23 14:47:19
Message-ID: CAOsNvwyy7sv-0VisZc4buRF20o=xSSA6_0Ru90CYQficD=dFLg () mail ! gmail ! com
[Download RAW message or body]

On 23 October 2017 at 16:20, Zebediah Figura <z.figura12@gmail.com> wrote:
> On 10/23/2017 02:29 AM, Henri Verbeet wrote:
>>
>> On 22 October 2017 at 00:32, Zebediah Figura <z.figura12@gmail.com> wrote:
>>>
>>> This should fix a persistent crash on one of the XP test machines.
>>>
>>> Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
>>> ---
>>
>> Why does it fail? It shouldn't. Does this run against Microsoft's
>> ddraw, or against some VM replacement?
>>
>>
>
> Hmm, I don't know; I just assumed it would be good to fix. It's this one:
>
> http://test.winehq.org/data/aef2f0799f09595f3458d3495e85bba0c9059865/xp_xpsp4v3.1b/version.html
>
>
"VirtualBox Graphics Adapter"

If we care to avoid the crash, it would perhaps be best to just skip
(using something along the lines of is_warp()) all the tests at the
start. VirtualBox results aren't going to be meaningful.



[prev in list] [next in list] [prev in thread] [next in thread]