[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 2/2] fonts: Increase the Em size to fix a build failure with freetype 2.8.1
From:       Michael Stefaniuc <mstefani () winehq ! org>
Date:       2017-09-28 8:19:51
Message-ID: 990e2135-4e0a-4296-eb48-dce88fd8619b () winehq ! org
[Download RAW message or body]

On 09/28/2017 10:07 AM, Dmitry Timoshkov wrote:
> Michael Stefaniuc <mstefani@winehq.org> wrote:
> 
>>> Did you test that after this patch font and glyph metrics still stay the same?
>> To find the relevant changes I have verified that the numbers increased
>> by the factor of 2048 divided by the old Em size (11 or 13 or 15). Of
>> course as 11, 13, 15 aren't factors of 2048 there are rounding errors.
>>
>> But it doesn't matter as:
>> a) Those are bitmap only fonts.
>> b) Only the *.fon files are installed but not the corresponding *.ttf files.
> 
> That's true, but it's sometimes useful to be able to load and test .ttf
> files as well, although it looks like after some Windows update intermediate
> Wine bitmap-only .ttf fonts is no longer possible to load under Windows, and
> since freetype 2.8.1 Linux started to behave same way.
Seems the Em increase fixed that on Windows too:
<nsivov> puk, with fixed em field ttfs open now on windows too

>> c) The generated *.fon files are bit by bit identical (sha1sum) before
>> and after this commit.
> 
> Great, that's the key point.
Right, that's why I have included that info in my patch submission ;)
https://www.winehq.org/pipermail/wine-patches/2017-September/165357.html

"With this two patches applied I always get the exact same fon files for
all possible combinations:
- freetype 2.6.5 and unpatched Wine
- freetype 2.6.5 and this two patches applied
- freetype 2.8.1 and this two patches applied"


bye
	michael



[prev in list] [next in list] [prev in thread] [next in thread]