[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: vbscript: Improve parsing of separators in loops and switches.
From:       Jacek Caban <jacek () codeweavers ! com>
Date:       2017-09-22 13:31:00
Message-ID: 9a5c4031-5c91-114c-8788-f6f6bc6bdff3 () codeweavers ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi Dmitry,

Thanks for the patch, it generally looks good. I have a few comments bellow.

On 20.09.2017 05:48, Dmitry Kislyuk wrote:
>  
> +StSeps
> +    : StSep
> +    | StSep StSeps

Since you're changing all uses of StSep, I think it would make more
sense to change StSep itself to accept multiple separator.

>  x = 0
> -Do While x < 2 : x = x + 1
> +Do While x < 2 :
> +x = x + 1
>  Loop
>  Call ok(x = 2, "x not equal to 2")

Please don't change existing tests like that. We want previous version
tested as well. Add new ones instead.

> @@ -511,7 +533,8 @@ Call collectionObj.reset()
>  y = 0
>  x = 10
>  z = 0
> -for each x in collectionObj : z = z + 2
> +for each x in collectionObj :
> +    :z = z + 2

Same here.

Thanks,
Jacek

[Attachment #5 (text/html)]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Hi Dmitry,<br>
      <br>
      Thanks for the patch, it generally looks good. I have a few
      comments bellow.<br>
      <br>
      On 20.09.2017 05:48, Dmitry Kislyuk wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:20170920034838.17557-1-dimaki@rocketmail.com">
      <div class="moz-text-plain" wrap="true" graphical-quote="true"
        style="font-family: -moz-fixed; font-size: 12px;"
        lang="x-unicode">
        <pre wrap=""> 
+StSeps
+    : StSep
+    | StSep StSeps</pre>
      </div>
    </blockquote>
    <br>
    Since you're changing all uses of StSep, I think it would make more
    sense to change StSep itself to accept multiple separator.<br>
    <br>
    <blockquote type="cite"
      cite="mid:20170920034838.17557-1-dimaki@rocketmail.com">
      <div class="moz-text-plain" wrap="true" graphical-quote="true"
        style="font-family: -moz-fixed; font-size: 12px;"
        lang="x-unicode">
        <pre wrap=""> x = 0
-Do While x &lt; 2 : x = x + 1
+Do While x &lt; 2 :
+x = x + 1
 Loop
 Call ok(x = 2, "x not equal to 2")</pre>
      </div>
    </blockquote>
    <br>
    Please don't change existing tests like that. We want previous
    version tested as well. Add new ones instead.<br>
    <br>
    <blockquote type="cite"
      cite="mid:20170920034838.17557-1-dimaki@rocketmail.com">
      <div class="moz-text-plain" wrap="true" graphical-quote="true"
        style="font-family: -moz-fixed; font-size: 12px;"
        lang="x-unicode">
        <pre wrap="">
@@ -511,7 +533,8 @@ Call collectionObj.reset()
 y = 0
 x = 10
 z = 0
-for each x in collectionObj : z = z + 2
+for each x in collectionObj :
+    :z = z + 2</pre>
      </div>
    </blockquote>
    <br>
    Same here.<br>
    <br>
    Thanks,<br>
    Jacek<br>
  </body>
</html>

[Attachment #6 (text/plain)]




[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic