[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH v2 10/11] progman: Use proper size for combobox controls
From:       Fabian Maurer <dark.shadow4 () web ! de>
Date:       2017-08-31 14:48:21
Message-ID: 20606934.MgLxfxkJyb () arch
[Download RAW message or body]

> > -COMBOBOX                              PM_TO_GROUP,         5, 38, 140,
> > 50, WS_TABSTOP | CBS_DROPDOWNLIST +COMBOBOX                             
> > PM_TO_GROUP,         5, 38, 140, 60, WS_TABSTOP | CBS_DROPDOWNLIST
> That kind of change doesn't seem necessary. We don't need all comboboxes
> to have the exact same height, only something reasonable.

Well, my intention was to keep the size the same as it was before my patch. 
Wine used to make comboboxes at least 5 items in height, that was the broken 
behavior, and since I didn't want to cause a change in look I decided to set 
it to a height of 60, which equals 5 items in height again.

I'm fine with the height being different of course, just give me your ok and 
I'll provide an updated patchset. Need to know what the minimal size you deem 
ok is though, to me 5 items in the drop down list looks fine, but only 2 or 3 
is a bit small in my opinion...

Regards,
Fabian Maurer



[prev in list] [next in list] [prev in thread] [next in thread]