[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 3/3] d3d9/tests: Add test for SW shader in MVP mode.
From:       Henri Verbeet <hverbeet () gmail ! com>
Date:       2017-08-24 15:42:25
Message-ID: CAOsNvwyYKcCkm=7JKMnsPY7wBcpbU0vLjPD_51tC9XZQx97CWg () mail ! gmail ! com
[Download RAW message or body]

On 24 August 2017 at 17:27, Paul Gofman <gofmanp@gmail.com> wrote:
> On 08/24/2017 04:39 PM, Henri Verbeet wrote:
>> On 23 August 2017 at 16:17, Paul Gofman <gofmanp@gmail.com> wrote:
>>> +    /* wined3d does not guarantee 0 for out of bounds constant access by
>>> default. */
>>
>> IIRC neither does Windows, in general. Matteo may have a better
>> recollection of the details, but IIRC while it mostly works out in
>> practice on current NVIDIA hardware, it doesn't necessarily everywhere
>> else, and is essentially hardware/driver specific behaviour.
>>
> So should I maybe change the test not to check for exact value but rather
> for not matching constant c256?
>
It might still match by chance. Perhaps it's best to just not test the
result of the draw and instead document why.



[prev in list] [next in list] [prev in thread] [next in thread]