[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [4/6] wsdapi: Implement "Hello" message creation support.
From:       Owen Rudge <owen () owenrudge ! net>
Date:       2017-07-31 20:40:42
Message-ID: 55dea788-ebb4-3cd1-6aa7-101356add477 () owenrudge ! net
[Download RAW message or body]

On 27/07/2017 22:11, Vincent Povirk wrote:

 > I really hope we don't have to start optimizing for fewer 
GetProcessHeap calls.

I'll amend. :)

 > This doesn't account for the terminating NULL wsprintfW will add.

Thanks for catching that.

 > +    discoveredNamespaces = WSDAllocateLinkedMemory(NULL, 
sizeof(struct list));
 > +    if (!discoveredNamespaces) goto cleanup;
 >
 > Why not allocate this on the stack?

The discovered namespaces (and their child strings) are linked to the 
parent namespace (and ultimately the discoveredNamespaces list), 
simplifying cleanup.

Cheers,

-- 
Owen Rudge
http://www.owenrudge.net/



[prev in list] [next in list] [prev in thread] [next in thread]