[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH v3 2/3] uiribbon: Add interface definitions
From:       Alistair Leslie-Hughes <leslie_alistair () hotmail ! com>
Date:       2017-07-29 23:12:55
Message-ID: SL2P216MB074608453A772D43328AB45A93BC0 () SL2P216MB0746 ! KORP216 ! PROD ! OUTLOOK ! COM
[Download RAW message or body]

Hi Fabian,

On 30/07/17 06:36, Fabian Maurer wrote:
> Code taken and adapted from d3dxof.
> 
> Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
> ---
>  dlls/uiribbon/Makefile.in          |   2 +
>  dlls/uiribbon/uiribbon_classes.idl |  21 +++++
These changes don't make any sense for this patch. Move them
to the third patch in which the interfaces are registered.

Besides this, everything looks ok.

Best Regards
 Alistair


[prev in list] [next in list] [prev in thread] [next in thread]