[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] winmm: Load MCI drivers from MCI32 key.
From:       Zebediah Figura <z.figura12 () gmail ! com>
Date:       2017-07-28 3:52:08
Message-ID: 0151ebbf-f80e-dd2d-798b-80b9d7f7754e () gmail ! com
[Download RAW message or body]

On 07/27/2017 08:40 AM, Andrew Eikum wrote:
> On Wed, Jul 26, 2017 at 06:45:32PM -0500, Zebediah Figura wrote:
>> On 07/26/2017 08:03 AM, Andrew Eikum wrote:
>>> This looks good, but could you add some tests showing something that
>>> was wrong before but is now fixed?
>>>
>>
>> The application overwrites the value of MCI/avivideo in system.ini (to
>> 16-bit mciavi.drv). Is this appropriate for a test?
>>
> 
> Maybe I misunderstood the impact of this patch. Won't it affect things
> like MCI_SYSINFO_QUANTITY, and other places that use those registry
> keys?
> 
> Andrew
> 

Yes, and that is the correct behaviour. I can write tests to demonstrate 
this if desired.



[prev in list] [next in list] [prev in thread] [next in thread]