[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] gdiplus: Add stub for GdipGraphicsSetAbort
From:       Andrew Eikum <aeikum () codeweavers ! com>
Date:       2017-07-27 12:46:19
Message-ID: 20170727124619.GE18609 () foghorn ! codeweavers ! com
[Download RAW message or body]

On Thu, Jul 27, 2017 at 01:01:51PM +0800, Dmitry Timoshkov wrote:
> Andrew Eikum <aeikum@codeweavers.com> wrote:
> 
> > +static void test_GdipGraphicsSetAbort(void)
> > +{
> > +    HDC hdc = GetDC(hwnd);
> > +    GpStatus status;
> > +    GpGraphics *graphics;
> > +
> > +    if (!pGdipGraphicsSetAbort)
> > +    {
> > +        win_skip("GdipGraphicsSetAbort() is not supported.\n");
> > +        return;
> 
> hdc is leaked.
> 
> > +    }
> > +
> > +    status = GdipCreateFromHDC(hdc, &graphics);
> > +    expect(Ok, status);
> > +
> > +    status = pGdipGraphicsSetAbort(NULL, NULL);
> > +    expect(InvalidParameter, status);
> > +
> > +    status = pGdipGraphicsSetAbort(graphics, NULL);
> > +    expect(Ok, status);
> > +
> > +    ReleaseDC(hwnd, hdc);
> > +}
> 
> graphics is leaked.
> 

Thanks for the review, will fix!

Andrew



[prev in list] [next in list] [prev in thread] [next in thread]